Fix PublicKeyCredentialType.PUBLIC_KEY comparison with Spring Session#17223
Closed
ltanguy wants to merge 5 commits into
Closed
Fix PublicKeyCredentialType.PUBLIC_KEY comparison with Spring Session#17223ltanguy wants to merge 5 commits into
ltanguy wants to merge 5 commits into
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
rwinch
requested changes
Jun 17, 2025
rwinch
added
in: web
rwinch
changed the title
Author
|
Thanks for the feedback. |
spring-projects-issues
added
status: feedback-provided
Replace comparison with != operator by an .equals() comparison based on text value. The 2 objects have the same value in most setups, but not when used in conjunction with Spring Session for example, as the object in session is built for each request Signed-off-by: ltanguy <loeiz.tanguy@gmail.com> Signed-off-by: Loeiz TANGUY <loeiz.tanguy@gmail.com>
…rializable Signed-off-by: Loeiz TANGUY <loeiz.tanguy@gmail.com>
Signed-off-by: Loeiz TANGUY <loeiz.tanguy@gmail.com>
Signed-off-by: Loeiz TANGUY <loeiz.tanguy@gmail.com>
|
Any update on this please? Been holding off implementing passkeys as would require the same changes made here. |
Author
|
@rwinch Is there something else expected on this pull request ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace comparison based on the != operator by an .equals() comparison based on the text value. The 2 objects have the same value in most setups, but not when used in conjunction with Spring Session for example, as the object in session is built for each request.
Fixes gh-17164